Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 25, 2018 21:48:00 GMT
Okay, so I want to know if anyone here knows the steps to reproduce the bug where bans "don't work". The issue can't be the bans not saving, because right after a ban is added the ban information is added to the bans.yml file immediately. Allegedly, the issue is aero can't find the player's ip, which doesn't make sense because the issue only happens with temp-banning, and it currently only works with online players (however, I plan on making it work offline as soon, but I don't want to do this with a bug with grabbing ips when a player is online. I can't figure out how to make this happen, and I really would like to know the root cause of the issue. If anyone knows how this happens, please respond in this thread.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 25, 2018 21:53:21 GMT
^^ When temp banning a player and they rejoin and you have to manually ban their ip is what he's referring to. I believe the cause is that it is unable to get the IP and then the ips: part ends up being null
|
|
StevenNL2000
Forum Admin 
Posts: 6,415
| Likes: 6,936
IGN: StevenNL2000
Timezone: UTC+01:00
Member is Staff. Need immediate assistance? Send a PM
|
Post by StevenNL2000 on Jul 25, 2018 22:24:07 GMT
^^ When temp banning a player and they rejoin and you have to manually ban their ip is what he's referring to. I believe the cause is that it is unable to get the IP and then the ips: part ends up being null TFM does have some weird inconsistencies with IPs, but I've never seen a nullPointerException before when it happened. The Bukkit API would never silently fail a YAML config write, would it? |
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 25, 2018 22:30:22 GMT
^^ When temp banning a player and they rejoin and you have to manually ban their ip is what he's referring to. I believe the cause is that it is unable to get the IP and then the ips: part ends up being null TFM does have some weird inconsistencies with IPs, but I've never seen a nullPointerException before when it happened. The Bukkit API would never silently fail a YAML config write, would it? I have not seen a NPE either. I think its a similar issue to how when you /seen a person and their name shows up twice. Maybe it would have to do with more than one person logging in with that username (therefore multiple IPs) and TFM for some reason doesn't ban the correct one |
|
StevenNL2000
Forum Admin
Posts: 6,415
| Likes: 6,936
IGN: StevenNL2000
Timezone: UTC+01:00
Member is Staff. Need immediate assistance? Send a PM
|
Post by StevenNL2000 on Jul 25, 2018 22:50:14 GMT
TFM does have some weird inconsistencies with IPs, but I've never seen a nullPointerException before when it happened. The Bukkit API would never silently fail a YAML config write, would it? I have not seen a NPE either. I think its a similar issue to how when you /seen a person and their name shows up twice. Maybe it would have to do with more than one person logging in with that username (therefore multiple IPs) and TFM for some reason doesn't ban the correct one If that was the case, they wouldn't be able to join back because there would still be a username ban in effect. |
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 25, 2018 23:14:35 GMT
I have not seen a NPE either. I think its a similar issue to how when you /seen a person and their name shows up twice. Maybe it would have to do with more than one person logging in with that username (therefore multiple IPs) and TFM for some reason doesn't ban the correct one If that was the case, they wouldn't be able to join back because there would still be a username ban in effect. Well if you try to ban an offline player with /tempban or /tban it says that the player wasn't found. The code used for gtfo (which seems to work everytime) is actually different than the one used in tempban. I'm going to use /gtfos code and see how that goes |
|
StevenNL2000
Forum Admin
Posts: 6,415
| Likes: 6,936
IGN: StevenNL2000
Timezone: UTC+01:00
Member is Staff. Need immediate assistance? Send a PM
|
Post by StevenNL2000 on Jul 26, 2018 0:14:06 GMT
|
|
