Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on May 21, 2018 18:55:24 GMT
Hi All, Just to let you know I've gotten around to fixing some of the bugs we found in the initial 5.1 Alpha release for Minecraft 1.12. Apologies its taken so long but I only really got around to doing it yesterday and haven't had much time before now to look at it. Please be aware this is still classed as a pre-release and I haven't done masses of testing, so please do be aware of that if you update your plugin. The other major change is Java 8 is now a requirement, I will be looking at Java 10 in the future but given 9 is already EOL and Netbeans doesn't have the ability to work with 10 yet thats a pain. Anyway you can see the full change log for this update and download the update here - github.com/TotalFreedom/TotalFreedomMod/releases/tag/V5.1.1-alpha2Any issues please do let me know! Regards Ryan |
|
StevenNL2000
Forum Admin 
Posts: 6,415
| Likes: 6,936
IGN: StevenNL2000
Timezone: UTC+01:00
Member is Staff. Need immediate assistance? Send a PM
|
Post by StevenNL2000 on May 21, 2018 19:56:57 GMT
Is there already a plan to merge this into TFPatches, or is someone just going to mash them together? It's good to see that the official repository isn't dead, but let's face it, we're not going to switch back to it anytime soon.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on May 21, 2018 20:21:31 GMT
Is there already a plan to merge this into TFPatches, or is someone just going to mash them together? It's good to see that the official repository isn't dead, but let's face it, we're not going to switch back to it anytime soon. TFPatches is an unsupported variant the same as CJFreedomMod was. If TotalFreedom wishes to continue their modified variant they would need to pull our changes down into their repo. If they have a list of changes they can raise issues and we can tag them as "Already Patched" the same as the patches Marco and Commodore did, but officially there is no plan to support a 3rd party variant of the official repo that I am aware of. |
|
_Windows
Club 4000 Member
Posts: 7,881
| Likes: 9,611
|
Post by _Windows on May 22, 2018 1:54:00 GMT
Is there already a plan to merge this into TFPatches, or is someone just going to mash them together? It's good to see that the official repository isn't dead, but let's face it, we're not going to switch back to it anytime soon. Well, also there'd need to be some testing done to make sure configs get transferred correctly as I'm assuming there may be differences there. Wild1145 thanks for the update. |
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on May 22, 2018 2:28:47 GMT
Well, also there'd need to be some testing done to make sure configs get transferred correctly as I'm assuming there may be differences there. Wild1145 thanks for the update. The configs are different, there are many changes to it. If TotalFreedom wishes to continue their modified variant they would need to pull our changes down into their repo. The changes made on the official repo are already on Lemon and I's third party variant. Is there already a plan to merge this into TFPatches, or is someone just going to mash them together? It's good to see that the official repository isn't dead, but let's face it, we're not going to switch back to it anytime soon. I'd like to get back to using it as soon as possible, but if we're going the route of creating an issue on the official repo for every change made on TFPatches it's not going to be worth the time. All the changes on the official repo are on TFPatches, but I can't just create a merge pull request as the official changes were added via another commit which will cause github to reject them for "compatibility issues". |
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on May 22, 2018 17:44:53 GMT
Well, also there'd need to be some testing done to make sure configs get transferred correctly as I'm assuming there may be differences there. Wild1145 thanks for the update. The configs are different, there are many changes to it. If TotalFreedom wishes to continue their modified variant they would need to pull our changes down into their repo. The changes made on the official repo are already on Lemon and I's third party variant. Is there already a plan to merge this into TFPatches, or is someone just going to mash them together? It's good to see that the official repository isn't dead, but let's face it, we're not going to switch back to it anytime soon. I'd like to get back to using it as soon as possible, but if we're going the route of creating an issue on the official repo for every change made on TFPatches it's not going to be worth the time. All the changes on the official repo are on TFPatches, but I can't just create a merge pull request as the official changes were added via another commit which will cause github to reject them for "compatibility issues". Its down to you guys if you want to merge / can merge it in. If the functionality is already there it seems pointless to do. Unfortunately I do not know what is in TFPatches that is different, so we would need issues raised and explained so we know what stuff has been changed and if it is something we would want to support in the main repo. I am hoping once I get this release finalised that I can start working on bringing some of the old changes Marco and Commodore had made into the official Repo as there are already some PR's that just need to be reviewed to achieve this and then add the other required functionality. |
|
super
Veteran Member
Among Us
Posts: 1,282
|
Post by super on May 22, 2018 18:24:04 GMT
Nice job, Wild.
|
|
