|
|
Post by Simpson_Manor on Dec 27, 2019 13:18:38 GMT
When the new itemizer was introduced. Enchant, Attribute, and Flags features are gone, so people are confused about it.
OP Item creations are starting to losing, every few players were switching to NBT Editors and IIE. And we cannot do anything since people chose Old Itemizer to make good op weapons easy.
So devs, why did you do it. People love it and we thought you fixed the glitches/bugs from the old one but Itemizer Remastered is a bad remastered plugin.
Revert it, please.
|
|
Steeved
Member
Posts: 19
| Likes: 0
|
Post by Steeved on Dec 27, 2019 13:25:28 GMT
I agree with you Suitch. But there is something that you are missing here. there is no version of itemiser that can modify any kind of attributes if the server is on version 1.14.4 so only enchants lores and names remain.We need it fixed for Minecraft 1.14.4 so it can modify attribute modifiers, ten we can apply it.
Although before the plugin broke almost every player in the server was using attributes to make Op things, now noone does and no one knows about them.
|
|
super
Veteran Member
Among Us
Posts: 1,282
|
Post by super on Dec 27, 2019 16:01:17 GMT
i agree. taah removed many core features of itemizer that made it unique. i'll try to revise itemizer's source and make it stable, but keep all of its features. thank you for this suggestion.
|
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Dec 28, 2019 14:35:00 GMT
I'm recreating Itemizer (now called ItemizerX) which should have all of features restored. Once I have finished creating it for 1.14.4, I'll quickly add a support for 1.15. The plugin is expected to be ready in a few days.
|
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Dec 29, 2019 5:48:27 GMT
I have finished creating ItemizerX for 1.14.4 and it's ready to be on server. DM me on discord to receive the jar file. However in 1.14.4 there aren't any permission nodes or any permission stuff in it. I have started working on 1.15 version and everything but attributes are working. Spigot 1.15 has changed the NBT a bit so I got a little more work to do to ensure the attributes are working.
The source code for ItemizerX is private and is currently on my GitHub and I'll give the code the developers once I finished 1.15 - however I expect the developers to keep the code private.
EDIT UPDATE: I have finished the 1.15 update, everything seems to be functional.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Dec 29, 2019 15:20:48 GMT
however I expect the developers to keep the code private. An excellent reason we probably should not run home-brew code on the server... We've had this discussion a number of times and last time it bit is in the arse when people ignored it. I don't get why if it's home-brew it's not open source, or we just use "Standard" and "Mainstream" plugins, not home-brew's... |
|
Video
Forum Admin 
An op's rights activist
Posts: 5,585
| Likes: 5,893
IGN: VideoGameSmash12, videogamesm12
Old IGN: https://namemc.com/profile/VideoGameSmash12.2, https://namemc.com/profile/videogamesm12.1
Discord: Video#9801
Birthdate (MM/DD): 07/16
Timezone: UTC-07:00
Member is Staff. Need immediate assistance? Send a PM
|
Post by Video on Dec 29, 2019 19:43:44 GMT
I don't get why if it's home-brew it's not open source, or we just use "Standard" and "Mainstream" plugins, not home-brew's... The reason we started using "home-brew" code was because the "standard" Itemizer was incredibly fucked. It threw a temper tantrum if you tried to make it do something in a way it didn't like. Don't believe me? Here are some logs to prove it, along with an explanation to prove how fucked it was. Not having a check for if lore even exists in the item in the first place: :[21:04:49 INFO]: VideoGameSmash12 issued server command: /it lore change 0 0
:[21:04:49 ERROR]: nullorg.bukkit.command.CommandException: Unhandled exception executing command 'it' in plugin Itemizer v3.5
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:710)
at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1641)
at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1481)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:1)
at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19)
at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:144)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:118)
at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:909)
at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:902)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(SourceFile:103)
at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:885)
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:819)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
at java.util.ArrayList.<init>(ArrayList.java:178)
at me.baks.items.Manager.changeLore(Manager.java:132)
at me.baks.items.Commands.onCommand(Commands.java:80)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
... 17 more
Not having a check for whether the equipped item is a sign or not before trying to fuck with sign attributes: :[21:06:02 INFO]: VideoGameSmash12 issued server command: /it sign
:[21:06:02 ERROR]: nullorg.bukkit.command.CommandException: Unhandled exception executing command 'it' in plugin Itemizer v3.5
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:710)
at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1641)
at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1481)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:1)
at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19)
at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:144)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:118)
at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:909)
at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:902)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(SourceFile:103)
at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:885)
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:819)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NoSuchFieldError: SIGN_POST
at me.baks.items.Utils.checkCursorBlock(Utils.java:21)
at me.baks.items.Commands.onCommand(Commands.java:44)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
... 17 more
Not having a condition where a provided enchantment doesn't exist: :[21:13:03 INFO]: VideoGameSmash12 issued server command: /it enchant add DAMAGE_Al 32767
:[21:13:03 ERROR]: nullorg.bukkit.command.CommandException: Unhandled exception executing command 'it' in plugin Itemizer v3.5
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:710)
at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1641)
at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1481)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:1)
at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19)
at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:144)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:118)
at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:909)
at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:902)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(SourceFile:103)
at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:885)
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:819)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalArgumentException: Cannot add null enchantment
at org.apache.commons.lang.Validate.notNull(Validate.java:192)
at org.bukkit.craftbukkit.v1_14_R1.inventory.CraftItemStack.addUnsafeEnchantment(CraftItemStack.java:178)
at me.baks.items.Manager.addEchant(Manager.java:269)
at me.baks.items.Commands.onCommand(Commands.java:171)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
... 17 more
Not having a condition where the player forgets to add all of the arguments to /it enchant add: :[21:07:16 INFO]: VideoGameSmash12 issued server command: /it enchant add DAMAGE_ALl
:[21:07:16 ERROR]: nullorg.bukkit.command.CommandException: Unhandled exception executing command 'it' in plugin Itemizer v3.5
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
at org.bukkit.craftbukkit.v1_14_R1.CraftServer.dispatchCommand(CraftServer.java:710)
at net.minecraft.server.v1_14_R1.PlayerConnection.handleCommand(PlayerConnection.java:1641)
at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1481)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:47)
at net.minecraft.server.v1_14_R1.PacketPlayInChat.a(PacketPlayInChat.java:1)
at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19)
at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(SourceFile:144)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(SourceFile:118)
at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:909)
at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:902)
at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.awaitTasks(SourceFile:127)
at net.minecraft.server.v1_14_R1.MinecraftServer.sleepForTick(MinecraftServer.java:886)
at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:819)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ArrayIndexOutOfBoundsException: 3
at me.baks.items.Commands.onCommand(Commands.java:171)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
... 17 moreTell me, would you rather have a plugin that constantly spams the console due to the uninformed player or a plugin that is stable but isn't open source? |
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Dec 29, 2019 19:58:23 GMT
however I expect the developers to keep the code private. An excellent reason we probably should not run home-brew code on the server... We've had this discussion a number of times and last time it bit is in the arse when people ignored it. I don't get why if it's home-brew it's not open source, or we just use "Standard" and "Mainstream" plugins, not home-brew's... I’m planning to make it open-source soon but for now I’m just keeping it private since I only made this plugin a few days ago. |
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Dec 29, 2019 20:39:24 GMT
The reason we started using "home-brew" code was because the "standard" Itemizer was incredibly fucked. It threw a temper tantrum if you tried to make it do something in a way it didn't like. Don't believe me? Here are some logs to prove it, along with an explanation to prove how fucked it was. Seems like a sensible thing to do, it was just a question, I find it best not to assume people did things for the correct reason but instead because they felt like it. Though as you've said and demonstrated, the standard version seems fucky. My question then is 1) Is there a similar plugin that's mainstream we could use instead of home-brew. 2) Is the original plugin open source and could we fix the issues we're having and push it back in meaning we don't have to maintain another plugin 3) Do we even need the plugin in the first place. I don't know the answer to those questions, but they're the sort of things I'd be asking in a similar scenario at work if someone came to me and wanted to deploy home-brew code on operational infrastructure. It may be sensible to do, I'm just saying it should be the last resort. I’m planning to make it open-source soon but for now I’m just keeping it private since I only made this plugin a few days ago. That's cool, I'm just saying I personally don't think we should be pushing brand new plugins on to the server without a decent amount of testing, and the plugin either being "Mainstream" as it were, or Open Source so anyone can fork and maintain it if that's the route we go down. |
|
97
Veteran Member
RIP Telnet
Posts: 889
| Likes: 679
|
Post by 97 on Dec 29, 2019 22:14:25 GMT
In the meantime while this is getting fixed, I recommend mcstacker.net to make items no sponsor oh, and do the commands in singeplayer since command blocks aren't enabled. |
|
super
Veteran Member
Among Us
Posts: 1,282
|
Post by super on Dec 29, 2019 23:20:08 GMT
In the meantime while this is getting fixed, I recommend mcstacker.net to make items no sponsor oh, and do the commands in singeplayer since command blocks aren't enabled. its already ready for production lmao |
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Dec 30, 2019 0:14:22 GMT
The reason we started using "home-brew" code was because the "standard" Itemizer was incredibly fucked. It threw a temper tantrum if you tried to make it do something in a way it didn't like. Don't believe me? Here are some logs to prove it, along with an explanation to prove how fucked it was. Seems like a sensible thing to do, it was just a question, I find it best not to assume people did things for the correct reason but instead because they felt like it. Though as you've said and demonstrated, the standard version seems fucky. My question then is 1) Is there a similar plugin that's mainstream we could use instead of home-brew. 2) Is the original plugin open source and could we fix the issues we're having and push it back in meaning we don't have to maintain another plugin 3) Do we even need the plugin in the first place. I don't know the answer to those questions, but they're the sort of things I'd be asking in a similar scenario at work if someone came to me and wanted to deploy home-brew code on operational infrastructure. It may be sensible to do, I'm just saying it should be the last resort. I’m planning to make it open-source soon but for now I’m just keeping it private since I only made this plugin a few days ago. That's cool, I'm just saying I personally don't think we should be pushing brand new plugins on to the server without a decent amount of testing, and the plugin either being "Mainstream" as it were, or Open Source so anyone can fork and maintain it if that's the route we go down. I have done a lot of testing on the plugin to ensure the errors that video stated would not occur. |
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Dec 30, 2019 12:59:14 GMT
Did a lot more of testing and managed to get all errors similar to video sorted.
|
|
super
Veteran Member
Among Us
Posts: 1,282
|
Post by super on Dec 30, 2019 14:44:49 GMT
itemizerx is now on the server and will be updated for 1.15 when we push it to the server.
|
|
