Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 12, 2018 4:26:30 GMT
You say that but yet none of what you've mentioned was even touched in the latest release. Nobody has raised it as an issue with us before, and if there are bugs, they need to be raised properly so we can investigate. We are aware of a number of bugs we're looking to patch in the 5.1 release, but given everyone involved works full time, we don't want to half arse this through the release just because it needs to be released... Well sorry, but if I am going to release a piece of software, I am going to be under the assumption that it can theoretically last someone years if they never ever update. When I download a stable release of something, I sure as hell want it to be stable. Your 5.0.1 release is not. While I know that TFM has NMS so it basically won't work on any version that it's not designed for, there are smart people who will not waste resources updating everything and just install ViaVersion instead. Would you really want to spend lots of money upgrading an office of computers on Windows 7 to Windows 10 when you could just make your network secure and educate your employees? No... Quite simply put. We won't merge in a 3rd party fork, it's entirely unmanageable for us to QA & test everything in its entirety... We have these guidelines and rules for contributing for a reason. It's a pretty smart move to make. If you think that a commit is just going to be pushed for shits and giggles for no reason and no testing is done you would be most wrong. Every aspect on TFPatches TFM has been tested extensively hard by me and my rigorous nitpicking. Many of the issues present that I found would be better suited for long term release to be worked on rather than a simple commit for the 1.13 update. Which is why it's smart to merge. If you just got 5.0.1, 5.0.2 and 5.1 out of the way, development would be synced up for once and all the long term issues could be fixed down the road so I can actively work on the 1.13 branch without duplicating my own effort. No effort needs to be duplicated... You'd be wasting your time fixing the same issues fixed over the summer for the 1.13 release in TFM on TFPatches. Thats what I'm saying. Go ahead and don't take my advice, but you'll be wasting your time making it either the same or even more complicated than it needs to be. And heres some evidence to back me up DeadalusMod: TotalFreedomMod:
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 13, 2018 13:04:28 GMT
Well sorry, but if I am going to release a piece of software, I am going to be under the assumption that it can theoretically last someone years if they never ever update. When I download a stable release of something, I sure as hell want it to be stable. Your 5.0.1 release is not. And what I am trying to get to here, is identify any bugs as a result of the changes made in 5.0.1, any other bugs should be being raised and we will fixed where we can. I also feel we have different view's on the word "stable" because I've found no stability issues within TFM, but if you can provide some issues where it has caused a stability issue, I'm still waiting... While I know that TFM has NMS so it basically won't work on any version that it's not designed for, there are smart people who will not waste resources updating everything and just install ViaVersion instead. Would you really want to spend lots of money upgrading an office of computers on Windows 7 to Windows 10 when you could just make your network secure and educate your employees? I don't see how this has anything to do with what you're point is, but given you've made it, as a full time Infrastructure engineer, your argument there is flawed. There are a range of reasons you would want to upgrade from Win 7 to Win 10 in an enterprise environment, just securing your network is not good enough, and there is only so much you can do to educate users. It does not however prevent other real world risks and threats to the environment, including insider threats, user error or attacks from outside threats. Unless you're running an entirely air-gapped network there is always a risk of network intrusion and just improving your network security does not cover that. It's a pretty smart move to make. If you think that a commit is just going to be pushed for shits and giggles for no reason and no testing is done you would be most wrong. Every aspect on TFPatches TFM has been tested extensively hard by me and my rigorous nitpicking. Many of the issues present that I found would be better suited for long term release to be worked on rather than a simple commit for the 1.13 update. Which is why it's smart to merge. If you just got 5.0.1, 5.0.2 and 5.1 out of the way, development would be synced up for once and all the long term issues could be fixed down the road My point exactly, you've "QA'd" the ticket. Not me, or one of the TFM team. We will not blindly merge the repo's together, as that would remove any and all QA process from the main TFM team, or would require months of effort to get right. It's why if you want to merge features back up to the main TFM repo, use PR's. No effort needs to be duplicated... You'd be wasting your time fixing the same issues fixed over the summer for the 1.13 release in TFM on TFPatches. Thats what I'm saying. Go ahead and don't take my advice, but you'll be wasting your time making it either the same or even more complicated than it needs to be. And heres some evidence to back me up DeadalusMod: Effort will be duplicated if I am fixing bugs in two branches that are the same, as I would be if I was working on the 1.12 and 1.13 branch in parallel, that I why I want to get this release done, so I can merge the 1.12 branch back into devel, and then start working on the 1.13 branch before releasing and merging that back in, and then I can start looking at 5.1 in its entirety. DeadalusMod was designed to cover functionality that will never be merged into TFM in a easy and hacky way just to get it working, that functionality will likely never make it into TFM.
|
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Oct 14, 2018 9:54:12 GMT
It's good to see that the official TotalFreedomMod is being updated, but if I was to be honest, I wouldn't use it.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 14, 2018 20:37:43 GMT
We've ran into an issue with the build pipeline with the main TFM plugin due to TF-WorldEdit being so old, so I'm working to get that up to date and the dependencies there working in a fully automated CI Pipeline, because I've not yet found anywhere that does that which works with the TF-WorldEdit, once that's done and the version for TFM is updated I hope to get the last couple of fixes done and the 1.12.2 build finalised before picking up work on 1.13.
Any other issues you pick up on the server please do let me know.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 14, 2018 20:38:58 GMT
We've ran into an issue with the build pipeline with the main TFM plugin due to TF-WorldEdit being so old, so I'm working to get that up to date and the dependencies there working in a fully automated CI Pipeline, because I've not yet found anywhere that does that which works with the TF-WorldEdit, once that's done and the version for TFM is updated I hope to get the last couple of fixes done and the 1.12.2 build finalised before picking up work on 1.13. Any other issues you pick up on the server please do let me know. I have a tf worldedit that's up to date for 1.12.2 and 1.13 1.12.2 <dependency> <groupId>com.github.Telesphoreo.TF-WorldEdit</groupId> <artifactId>worldedit-bukkit</artifactId> <version>2e79570525</version> <scope>provided</scope> </dependency> 1.13 <dependency> <groupId>com.github.Telesphoreo</groupId> <artifactId>TF-Worldedit</artifactId> <version>38ff62899c</version> </dependency>
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 14, 2018 20:41:37 GMT
We've ran into an issue with the build pipeline with the main TFM plugin due to TF-WorldEdit being so old, so I'm working to get that up to date and the dependencies there working in a fully automated CI Pipeline, because I've not yet found anywhere that does that which works with the TF-WorldEdit, once that's done and the version for TFM is updated I hope to get the last couple of fixes done and the 1.12.2 build finalised before picking up work on 1.13. Any other issues you pick up on the server please do let me know. I have a tf worldedit that's up to date for 1.12.2 and 1.13 Have you got a link to what is currently running on TF for WorldEdit?
|
|
Fleek
Veteran Member
Posts: 3,548
|
Post by Fleek on Oct 14, 2018 20:41:51 GMT
We've ran into an issue with the build pipeline with the main TFM plugin due to TF-WorldEdit being so old, so I'm working to get that up to date and the dependencies there working in a fully automated CI Pipeline, because I've not yet found anywhere that does that which works with the TF-WorldEdit, once that's done and the version for TFM is updated I hope to get the last couple of fixes done and the 1.12.2 build finalised before picking up work on 1.13. Any other issues you pick up on the server please do let me know. I have a tf worldedit that's up to date for 1.12.2 and 1.13 Yes, please use this WorldEdit than rather wasting your time making up-to-date version.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 14, 2018 20:42:56 GMT
I have a tf worldedit that's up to date for 1.12.2 and 1.13 Have you got a link to what is currently running on TF for WorldEdit? Edited post for what to use in jitpack I have up to date versions for all plugins here github.com/Telesphoreo?tab=repositories
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 14, 2018 20:43:52 GMT
I have a tf worldedit that's up to date for 1.12.2 and 1.13 Yes, please use this WorldEdit than rather wasting your time making up-to-date version. So it will depend what version it is based off of. I've already decided the new 7.0.0-SNAPSHOT build of WorldEdit is where the new version of TF-WorldEdit will be based off of. If that's already been created and is a mimic of what the current TF-WorldEdit is, that will work fine. If not it may be something we use as a dependency for the build for the time being while I then look to do the update at another time, as we want the new TF-WorldEdit to be as close features wise to the current one as possible, and ensure we continue to use the judgement we've exercised across the TotalFreedom Github organisation for project goals & such.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 14, 2018 20:44:20 GMT
Awesome, I'll have a look and see if that will work for what I need - Ta
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 14, 2018 20:47:34 GMT
^ worldedit is out of date on my repo but I haven't gotten time yet to merge the latest changes and test them. I run a test 1.13.1 server with the latest tf- plugins
I'll get around to updating everything today or tomorrow
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 14, 2018 21:04:05 GMT
^ worldedit is out of date on my repo but I haven't gotten time yet to merge the latest changes and test them. I run a test 1.13.1 server with the latest tf- plugins I'll get around to updating everything today or tomorrow The release on there seems to be working well. It's built properly locally and Travis is building it now. That should work perfectly while we get the official repo back up to date. Thank you
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 14, 2018 21:14:22 GMT
Thanks to @packsgaminghd and the TF-WorldEdit he has already updated the Release candidate has been updated and is now running which fixes the issues we were having with the build pipeline. I don't think any major issues have come out of this update, so my intent will be to merge this tomorrow and issue a full 5.0.1 release, before we start working on 5.0.2 for MC 1.13.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 15, 2018 18:00:29 GMT
Thank you to all those involved in the testing of the 5.0.1 release, it will be on Github soon, and a separate thread will be posted here soon.
|
|