Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 9, 2018 21:23:16 GMT
Hi All,
I am currently hoping to get an official 5.0.1 release of TFM out before this weekend, if I could get anyone with some spare time to have a look on the test server (https://totalfreedom.boards.net/thread/62173/tfm-development-server-launched) and play around with TFM functionality and report back on any issues you run into on this thread, that would be greatly appreciated, and that way I can look at if any of them are a result of the new release or just general issues we will fix in a later release.
Update - Thanks to @packsgaminghd and the TF-WorldEdit he has already updated the Release candidate has been updated and is now running which fixes the issues we were having with the build pipeline. I don't think any major issues have come out of this update, so my intent will be to merge this tomorrow and issue a full 5.0.1 release, before we start working on 5.0.2 for MC 1.13.
As soon as we get 5.0.1 (1.12.2) released, we will then be working on 5.0.2 (1.13) before the 5.1 release that will hopefully have some new functionality.
Please let me know any issues here, and thank you for your help!
Regards
Wild
|
|
fionn
Club 4000 Member
Admin Officer
elmon sucks
Posts: 6,157
| Likes: 4,775
|
Post by fionn on Oct 9, 2018 21:39:55 GMT
Yeah I’ll be on often
Edit: Mind coming on for a second?
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 10, 2018 0:53:35 GMT
here are some issues - you've completely buttfucked libsdisguises. github.com/Telesphoreo/TF-LibsDisguises builds correctly and is 1.13 or if you want the 1.12.2 version use tfpatches but there are api changes between each version so have fun with that - /debug has an old package name - wipeflatlands doesn't check if it is actually supposed to generate - whitelist purge doesn't work - you should apply the fix steven suggested at bare minimum for fixing the banning issues, but i reworked the banning code - /setl should check if worldedit is enabled - /ov should be renamed to /overlord - whoever wrote the grammar for /invis was drunk - /tfm reload is a nice alias for /tag clearall - denick should have an essentials check - also /tag list isnt in the /tag args - /cmdlist should have a space inbetween the stringutils.join method - the permbans module in the httpd should check if an admin is authorized - metrics needs to be switched, MCStats is now dead. i would advise switching to bStats - /overlord's unknown command message needs to have a / in help - as an extension on above, i would get the unknown command message from the SpigotConfig instead of hardcoding it - not sure if this was fixed but /cake hasn't been updated for the new achievements - npe in saconfig if the player == null when adding - bats and giants bypass mobblocker - spawnmobs usage is Make an announcement - spawnmobs for loop is broken - /spectator should be a command - yml files should be updated to 5.0.1 - pom.xml is a mess, needs to be reworked - please for the love of god change the versioning system - as a suggestion i would also change the buildDate to be like mm/dd/yy or whatever instead of using dashes - if this image is how the build system is going to work im gonna stop you right there muchacho. it fucking sucks. use mine, it works for how tfm is actually being worked on nowadays also the last problem: - you are not using the TFPatches version of TFM have a nice weekend
|
|
Waspter
Veteran Member
Advertising...
Posts: 3,237
| Likes: 315
|
Post by Waspter on Oct 10, 2018 9:40:26 GMT
here are some issues - you've completely buttfucked libsdisguises. github.com/Telesphoreo/TF-LibsDisguises builds correctly and is 1.13 or if you want the 1.12.2 version use tfpatches but there are api changes between each version so have fun with that - /debug has an old package name - wipeflatlands doesn't check if it is actually supposed to generate - whitelist purge doesn't work - you should apply the fix steven suggested at bare minimum for fixing the banning issues, but i reworked the banning code - /setl should check if worldedit is enabled - /ov should be renamed to /overlord - whoever wrote the grammar for /invis was drunk - /tfm reload is a nice alias for /tag clearall - denick should have an essentials check - also /tag list isnt in the /tag args - /cmdlist should have a space inbetween the stringutils.join method - the permbans module in the httpd should check if an admin is authorized - metrics needs to be switched, MCStats is now dead. i would advise switching to bStats - /overlord's unknown command message needs to have a / in help - as an extension on above, i would get the unknown command message from the SpigotConfig instead of hardcoding it - not sure if this was fixed but /cake hasn't been updated for the new achievements - npe in saconfig if the player == null when adding - bats and giants bypass mobblocker - spawnmobs usage is Make an announcement - spawnmobs for loop is broken - /spectator should be a command - yml files should be updated to 5.0.1 - pom.xml is a mess, needs to be reworked - please for the love of god change the versioning system - as a suggestion i would also change the buildDate to be like mm/dd/yy or whatever instead of using dashes - if this image is how the build system is going to work im gonna stop you right there muchacho. it fucking sucks. use mine, it works for how tfm is actually being worked on nowadays also the last problem: - you are not using the TFPatches version of TFM have a nice weekend
|
|
Aarooncia ?
Full Member
Honestly, what the fuck has happened?
Posts: 173
| Likes: 71
|
Post by Aarooncia ? on Oct 10, 2018 12:41:58 GMT
Hi All, I am currently hoping to get an official 5.0.1 release of TFM out before this weekend, if I could get anyone with some spare time to have a look on the test server (https://totalfreedom.boards.net/thread/62173/tfm-development-server-launched) and play around with TFM functionality and report back on any issues you run into on this thread, that would be greatly appreciated, and that way I can look at if any of them are a result of the new release or just general issues we will fix in a later release. As soon as we get 5.0.1 (1.12.2) released, we will then be working on 5.0.2 (1.13) before the 5.1 release that will hopefully have some new functionality. Please let me know any issues here, and thank you for your help! Regards Wild I’d be more than happy to help you out. DM me on Discord if you want me to come on. Aarooncia#5963
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 10, 2018 14:28:00 GMT
here are some issues - you've completely buttfucked libsdisguises. github.com/Telesphoreo/TF-LibsDisguises builds correctly and is 1.13 or if you want the 1.12.2 version use tfpatches but there are api changes between each version so have fun with that - /debug has an old package name - wipeflatlands doesn't check if it is actually supposed to generate - whitelist purge doesn't work - you should apply the fix steven suggested at bare minimum for fixing the banning issues, but i reworked the banning code - /setl should check if worldedit is enabled - /ov should be renamed to /overlord - whoever wrote the grammar for /invis was drunk - /tfm reload is a nice alias for /tag clearall - denick should have an essentials check - also /tag list isnt in the /tag args - /cmdlist should have a space inbetween the stringutils.join method - the permbans module in the httpd should check if an admin is authorized - metrics needs to be switched, MCStats is now dead. i would advise switching to bStats - /overlord's unknown command message needs to have a / in help - as an extension on above, i would get the unknown command message from the SpigotConfig instead of hardcoding it - not sure if this was fixed but /cake hasn't been updated for the new achievements - npe in saconfig if the player == null when adding - bats and giants bypass mobblocker - spawnmobs usage is Make an announcement - spawnmobs for loop is broken - /spectator should be a command - yml files should be updated to 5.0.1 - pom.xml is a mess, needs to be reworked - please for the love of god change the versioning system - as a suggestion i would also change the buildDate to be like mm/dd/yy or whatever instead of using dashes - if this image is how the build system is going to work im gonna stop you right there muchacho. it fucking sucks. use mine, it works for how tfm is actually being worked on nowadays also the last problem: - you are not using the TFPatches version of TFM have a nice weekend Oh yeah I should have made a separate issue for every single one of those issues my bad haha
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 11, 2018 8:53:29 GMT
here are some issues - you've completely buttfucked libsdisguises. github.com/Telesphoreo/TF-LibsDisguises builds correctly and is 1.13 or if you want the 1.12.2 version use tfpatches but there are api changes between each version so have fun with that - /debug has an old package name - wipeflatlands doesn't check if it is actually supposed to generate - whitelist purge doesn't work - you should apply the fix steven suggested at bare minimum for fixing the banning issues, but i reworked the banning code - /setl should check if worldedit is enabled - /ov should be renamed to /overlord - whoever wrote the grammar for /invis was drunk - /tfm reload is a nice alias for /tag clearall - denick should have an essentials check - also /tag list isnt in the /tag args - /cmdlist should have a space inbetween the stringutils.join method - the permbans module in the httpd should check if an admin is authorized - metrics needs to be switched, MCStats is now dead. i would advise switching to bStats - /overlord's unknown command message needs to have a / in help - as an extension on above, i would get the unknown command message from the SpigotConfig instead of hardcoding it - not sure if this was fixed but /cake hasn't been updated for the new achievements - npe in saconfig if the player == null when adding - bats and giants bypass mobblocker - spawnmobs usage is Make an announcement - spawnmobs for loop is broken - /spectator should be a command - yml files should be updated to 5.0.1 - pom.xml is a mess, needs to be reworked - please for the love of god change the versioning system - as a suggestion i would also change the buildDate to be like mm/dd/yy or whatever instead of using dashes - if this image is how the build system is going to work im gonna stop you right there muchacho. it fucking sucks. use mine, it works for how tfm is actually being worked on nowadays also the last problem: - you are not using the TFPatches version of TFM have a nice weekend It would appear you've not actually read the threads regarding this that would have told you the following: 1) TF Patches is not officially recognised as a replacement for TFM. TFM is still the officially supported freedom plugin, and if you want to fork off and play with it, that's your decision. This dev server is dedicated to supporting and testing the official TFM plugin and nothing else. 2) The only thing that has been updated on the dev server is TFM, and it's been updated to the latest candidate release, meaning i only care about bugs in the TFM version on there. 3) Most of the shit you've listed, are feature recommendations, or functionality not even within TFM. 4) I never asked for a code review yet you seem to have offered one anyway... If you have an issue with the code you should use the PR On GitHub to flag them, not this thread. If you've not got anything legitimately constructive to add, please do not waste everyone's time posting.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 11, 2018 14:03:29 GMT
here are some issues - you've completely buttfucked libsdisguises. github.com/Telesphoreo/TF-LibsDisguises builds correctly and is 1.13 or if you want the 1.12.2 version use tfpatches but there are api changes between each version so have fun with that - /debug has an old package name - wipeflatlands doesn't check if it is actually supposed to generate - whitelist purge doesn't work - you should apply the fix steven suggested at bare minimum for fixing the banning issues, but i reworked the banning code - /setl should check if worldedit is enabled - /ov should be renamed to /overlord - whoever wrote the grammar for /invis was drunk - /tfm reload is a nice alias for /tag clearall - denick should have an essentials check - also /tag list isnt in the /tag args - /cmdlist should have a space inbetween the stringutils.join method - the permbans module in the httpd should check if an admin is authorized - metrics needs to be switched, MCStats is now dead. i would advise switching to bStats - /overlord's unknown command message needs to have a / in help - as an extension on above, i would get the unknown command message from the SpigotConfig instead of hardcoding it - not sure if this was fixed but /cake hasn't been updated for the new achievements - npe in saconfig if the player == null when adding - bats and giants bypass mobblocker - spawnmobs usage is Make an announcement - spawnmobs for loop is broken - /spectator should be a command - yml files should be updated to 5.0.1 - pom.xml is a mess, needs to be reworked - please for the love of god change the versioning system - as a suggestion i would also change the buildDate to be like mm/dd/yy or whatever instead of using dashes - if this image is how the build system is going to work im gonna stop you right there muchacho. it fucking sucks. use mine, it works for how tfm is actually being worked on nowadays also the last problem: - you are not using the TFPatches version of TFM have a nice weekend It would appear you've not actually read the threads regarding this that would have told you the following: 1) TF Patches is not officially recognised as a replacement for TFM. TFM is still the officially supported freedom plugin, and if you want to fork off and play with it, that's your decision. This dev server is dedicated to supporting and testing the official TFM plugin and nothing else. 2) The only thing that has been updated on the dev server is TFM, and it's been updated to the latest candidate release, meaning i only care about bugs in the TFM version on there. 3) Most of the shit you've listed, are feature recommendations, or functionality not even within TFM. 4) I never asked for a code review yet you seem to have offered one anyway... If you have an issue with the code you should use the PR On GitHub to flag them, not this thread. If you've not got anything legitimately constructive to add, please do not waste everyone's time posting. You realize every issue I pointed out is an issue on the Total freedom organization. You asked us to find issues and I did. I don't think you know what the difference between an issue and a feature is. Let me clarify that for you. Adding glist nameban or ipban is a feature. Ok? A bug fix is changing the usage from "Make an announcement" to "Spawn a mob". Sure, there were some like add /spectator but that is an official game mode that admins should have access too. If you would like me to post them on github, make an actual issue for us to add stuff or at least tell us to post there in the first place. Again, you're welcome. It seems as if I've wasted my own time (again) to you to be helpful. P.S. I think the "official" TFM should be recognized as the one that's actually on the server, not an out of date one that hasn't been updated in a year or doesn't even generate worlds in 1.13. I bet you'll copy the code from there too just like you have without crediting me for my fixes to the pom.xml files. You should just merge TFPatches into the TotalFreedom organization. You have a very vague roadmap of releases, but TFPatches is already at your roadmap of a 5.1 release, so why are you wasting time writing much of the same code?
|
|
Video
Forum Admin
An op's rights activist
Posts: 5,585
| Likes: 5,893
IGN: VideoGameSmash12, videogamesm12
Old IGN: https://namemc.com/profile/VideoGameSmash12.2, https://namemc.com/profile/videogamesm12.1
Discord: Video#9801
Birthdate (MM/DD): 07/16
Timezone: UTC-07:00
Member is Staff. Need immediate assistance? Send a PM
|
Post by Video on Oct 11, 2018 14:36:47 GMT
here are some issues - you've completely buttfucked libsdisguises. github.com/Telesphoreo/TF-LibsDisguises builds correctly and is 1.13 or if you want the 1.12.2 version use tfpatches but there are api changes between each version so have fun with that - /debug has an old package name - wipeflatlands doesn't check if it is actually supposed to generate - whitelist purge doesn't work - you should apply the fix steven suggested at bare minimum for fixing the banning issues, but i reworked the banning code - /setl should check if worldedit is enabled - /ov should be renamed to /overlord - whoever wrote the grammar for /invis was drunk - /tfm reload is a nice alias for /tag clearall - denick should have an essentials check - also /tag list isnt in the /tag args - /cmdlist should have a space inbetween the stringutils.join method - the permbans module in the httpd should check if an admin is authorized - metrics needs to be switched, MCStats is now dead. i would advise switching to bStats - /overlord's unknown command message needs to have a / in help - as an extension on above, i would get the unknown command message from the SpigotConfig instead of hardcoding it - not sure if this was fixed but /cake hasn't been updated for the new achievements - npe in saconfig if the player == null when adding - bats and giants bypass mobblocker - spawnmobs usage is Make an announcement - spawnmobs for loop is broken - /spectator should be a command - yml files should be updated to 5.0.1 - pom.xml is a mess, needs to be reworked - please for the love of god change the versioning system - as a suggestion i would also change the buildDate to be like mm/dd/yy or whatever instead of using dashes - if this image is how the build system is going to work im gonna stop you right there muchacho. it fucking sucks. use mine, it works for how tfm is actually being worked on nowadays also the last problem: - you are not using the TFPatches version of TFM have a nice weekend It would appear you've not actually read the threads regarding this that would have told you the following: 1) TF Patches is not officially recognised as a replacement for TFM. TFM is still the officially supported freedom plugin, and if you want to fork off and play with it, that's your decision. This dev server is dedicated to supporting and testing the official TFM plugin and nothing else. 2) The only thing that has been updated on the dev server is TFM, and it's been updated to the latest candidate release, meaning i only care about bugs in the TFM version on there. 3) Most of the shit you've listed, are feature recommendations, or functionality not even within TFM. 4) I never asked for a code review yet you seem to have offered one anyway... If you have an issue with the code you should use the PR On GitHub to flag them, not this thread. If you've not got anything legitimately constructive to add, please do not waste everyone's time posting. 1. If TF itself uses TFPatches, then it is technically official. 2. You're testing an arguably outdated version of TFM that lacks many features and fixes that TFPatches has, and you only care about the bugs? 3. A lot of them are bugs, features, and other various issues that were solved in TFPatches. If your "official" version of it gets implemented, we would lose a LOT of useful changes and a literal fuckton of admins would complain and request that the changes be reverted. 4. Packs probably already did that. Also, his post was arguably constructive, listing many of the problems within it as a form of criticism.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 11, 2018 16:21:43 GMT
It would appear you've not actually read the threads regarding this that would have told you the following: 1) TF Patches is not officially recognised as a replacement for TFM. TFM is still the officially supported freedom plugin, and if you want to fork off and play with it, that's your decision. This dev server is dedicated to supporting and testing the official TFM plugin and nothing else. 2) The only thing that has been updated on the dev server is TFM, and it's been updated to the latest candidate release, meaning i only care about bugs in the TFM version on there. 3) Most of the shit you've listed, are feature recommendations, or functionality not even within TFM. 4) I never asked for a code review yet you seem to have offered one anyway... If you have an issue with the code you should use the PR On GitHub to flag them, not this thread. If you've not got anything legitimately constructive to add, please do not waste everyone's time posting. You realize every issue I pointed out is an issue on the Total freedom organization. You asked us to find issues and I did. I don't think you know what the difference between an issue and a feature is. Let me clarify that for you. Adding glist nameban or ipban is a feature. Ok? A bug fix is changing the usage from "Make an announcement" to "Spawn a mob". Sure, there were some like add /spectator but that is an official game mode that admins should have access too. If you would like me to post them on github, make an actual issue for us to add stuff or at least tell us to post there in the first place. Again, you're welcome. It seems as if I've wasted my own time (again) to you to be helpful. P.S. I think the "official" TFM should be recognized as the one that's actually on the server, not an out of date one that hasn't been updated in a year or doesn't even generate worlds in 1.13. I bet you'll copy the code from there too just like you have without crediting me for my fixes to the pom.xml files. You should just merge TFPatches into the TotalFreedom organization. You have a very vague roadmap of releases, but TFPatches is already at your roadmap of a 5.1 release, so why are you wasting time writing much of the same code? Actually, I asked for help testing the TFM 5.0.1 Candidate release, and identifying any bugs within the plugin, and not to go "This is in some other random plugin and compare it against another plugin, because an apple is a pear right?". With regards to the POM file, I believe I credited you in the commit messages, if I did not then please accept my apologies, and I will make a point to credit you clearly on the official release documents. As for the roadmap of TFPatches, that is irrelevant to me. As for TFPatches being "Official" that would be inaccurate given you have simply forked off of the main build... It would be the same as you calling TF-WorldEdit the official WorldEdit plugin, just because you forked it and it runs on the server. The changes we make at the TFM level should be pulled down in to forked projects if those projects intend to keep up to date. If there are features you want adding to TFM that are not currently on the roadmap, I would suggest you raise that on Github, this thread is only for issues directly relating to the 5.0.1 candidate release for TFM, as I mentioned previously.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 11, 2018 16:23:47 GMT
It would appear you've not actually read the threads regarding this that would have told you the following: 1) TF Patches is not officially recognised as a replacement for TFM. TFM is still the officially supported freedom plugin, and if you want to fork off and play with it, that's your decision. This dev server is dedicated to supporting and testing the official TFM plugin and nothing else. 2) The only thing that has been updated on the dev server is TFM, and it's been updated to the latest candidate release, meaning i only care about bugs in the TFM version on there. 3) Most of the shit you've listed, are feature recommendations, or functionality not even within TFM. 4) I never asked for a code review yet you seem to have offered one anyway... If you have an issue with the code you should use the PR On GitHub to flag them, not this thread. If you've not got anything legitimately constructive to add, please do not waste everyone's time posting. 1. If TF itself uses TFPatches, then it is technically official. 2. You're testing an arguably outdated version of TFM that lacks many features and fixes that TFPatches has, and you only care about the bugs? 3. A lot of them are bugs, features, and other various issues that were solved in TFPatches. If your "official" version of it gets implemented, we would lose a LOT of useful changes and a literal fuckton of admins would complain and request that the changes be reverted. 4. Packs probably already did that. Also, his post was arguably constructive, listing many of the problems within it as a form of criticism. 1) No, TF Patches is a fork of the Official TotalFreedomMod plugin, again like my previous post, just because you fork a plugin does not make it official. 2) This version of TFM is the latest build of TFM, forks are not something I care about, bugs in the upcoming release is. I do care about the feature difference in TF Patches, and if we want to align the two plugins, work can go into doing that. 3) Again, TF Patches is not at all relevant to this post. 4) If it has been done on the PR, it will be reviewed on that PR, not in a thread here where its more than a bit of a challenge to line up. The post would have been constructive if it was remotely related to the thread, and not a tangent on how TF Patches is better than its upstream plugin.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 11, 2018 17:24:21 GMT
Actually, I asked for help testing the TFM 5.0.1 Candidate release, and identifying any bugs within the plugin, and not to go "This is in some other random plugin and compare it against another plugin, because an apple is a pear right?". Uhh last time I checked TotalFreedomMod == TotalFreedomMod. You seem to be missing my point and think that these are bugs in TFPatches, when they are actually bugs in the official repository. Yes, TFPatches is a fork, but it's also the one that we are running on the server, so therefore it should be the official one.[quote author=" Wild1145 " source="/post/711375/thread" timestamp="1539274903"]It would be the same as you calling TF-WorldEdit the official WorldEdit plugin, just because you forked it and it runs on the server[/quote] What? Now thats comparing pears and apples because we didn't build the plugin from scratch. TotalFreedomMod was made from scratch by our developers, and whichever one we run should be the official one. If there are features you want adding to TFM that are not currently on the roadmap, I would suggest you raise that on Github, this thread is only for issues directly relating to the 5.0.1 candidate release for TFM, as I mentioned previously. Well jesus, sorry I'm trying to be helpful and save you months of development time. 2) This version of TFM is the latest build of TFM, forks are not something I care about, bugs in the upcoming release is. I do care about the feature difference in TF Patches, and if we want to align the two plugins, work can go into doing that. Maybe you should actually respond to Seth's messages regarding him making a pull request in merging the changes into the TotalFreedom repository then. The post would have been constructive if it was remotely related to the thread, and not a tangent on how TF Patches is better than its upstream plugin. Well it is, first of all. And again, all these issues aren't related to TFPatches and no one is forcing you to work on them. If you don't want to use my code review for the TotalFreedom organization, then go ahead, but many admins will be bitching about all the features removed.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 11, 2018 19:01:45 GMT
Uhh last time I checked TotalFreedomMod == TotalFreedomMod. You seem to be missing my point and think that these are bugs in TFPatches, when they are actually bugs in the official repository. The point I'm trying to make is these "Issues" you're raising are for functionality which is not even in the candidate release, it is for a unsupported fork of the plugin... All I have asked is for this thread to only include testing of the TotalFreedomMod plugin currently running on the dev server... Nothing more. Nothing less. What? Now thats comparing pears and apples because we didn't build the plugin from scratch. TotalFreedomMod was made from scratch by our developers, and whichever one we run should be the official one. No, TotalFreedomMod was originally written for this server, but when Marco & Commodore decided to turn it into the Wild West, a distinction was clearly made between TF developers & plugins, and the TFM developers and supported plugins. You have forked our plugin to modify it for your own needs, just as the TotalFreedom organisation did with WorldEdit, there is no difference in that regards. TFPatches may be the TF "Official" build, but it is not recognised as a TotalFreedomMod official build. Maybe you should actually respond to Seth's messages regarding him making a pull request in merging the changes into the TotalFreedom repository then. You mean the PR he raised in the last 48 hours? I've been talking to him on Discord about that and a number of different PR's and similar, and it is already in hand. Well it is, first of all. And again, all these issues aren't related to TFPatches and no one is forcing you to work on them. If you don't want to use my code review for the TotalFreedom organization, then go ahead, but many admins will be bitching about all the features removed I've at no point said I do not want a code review, I've said the code review should be on the PR where it can be reasonable actioned, not on here where its impossible to work out what you're talking about that relates to this build and what's random other stuff. TF may not choose to run this build, that's not my problem, it's down to the leadership team to make an educated decision on if they want to move back to an officially supported and sanctioned build of TotalFreedomMod, or stick with the Wild West that is TF Patches.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Oct 11, 2018 19:22:57 GMT
The point I'm trying to make is these "Issues" you're raising are for functionality which is not even in the candidate release, it is for a unsupported fork of the plugin... All I have asked is for this thread to only include testing of the TotalFreedomMod plugin currently running on the dev server... Nothing more. Nothing less. Yes it is. I checked every time to make sure everything I said was part of the TotalFreedom organization You mean the PR he raised in the last 48 hours? I've been talking to him on Discord about that and a number of different PR's and similar, and it is already in hand. . It's half baked though, and doesn't have player verification. Just merge the 1.13 branch, and you have your 5.0.1, 5.0.2, and 5.1 release finished. Making separate PR's is frankly a waste of time [tr][td class="content"][article]I've at no point said I do not want a code review, I've said the code review should be on the PR where it can be reasonable actioned, not on here where its impossible to work out what you're talking about that relates to this build and what's random other stuff. TF may not choose to run this build, that's not my problem, it's down to the leadership team to make an educated decision on if they want to move back to an officially supported and sanctioned build of TotalFreedomMod, or stick with the Wild West that is TF Patches. [/article] [/td] [/tr] [tr] [td class="foot"] [/td][/tr][/quote] You seem to have an outdated picture of what TFPatches is. I would have agreed that the TotalFreedom TFM was more stable than the one on TFPatches for 1.12 but thats no longer the case anymore. I spent many hours almost everyday going thru TFM and finding issues and making many things better. I would now recommend people using TFPatches. The last commit to TotalFreedom's TFM was over a year ago. The 1.13 branch doesn't work at all (world generation doesn't work) and the devel branch hasn't been updated since August 2017. TFPatches is managed by our active developers who have an actual rank. You really think you're a god because you manage the TotalFreedom organization which has been worked on, but you're not. It's no longer good, it's outdated, and the last release was two years ago. Pull requests are for merging code changes, and issues are where you make them. There is no issue or checklist or anything for the 5.0.1 release. There are no rigorous contribution guidelines on TFPatches and I would rather make quality commits for TFPatches than TotalFreedom. If you are seriously so organized that you have to have the code review on the GitHub, that's really not my problem. The development changelog is listed here and players check the forums, not a GitHub repository. That is the mistake I made with TF-EssentialsX by listing them on some obscure page rather than making an understandable changelog on the forums.
|
|
Wild1145
Club 4000 Member
Inactive Player & Inactive Senior Admin
Posts: 10,414
| Likes: 9,680
|
Post by Wild1145 on Oct 11, 2018 19:40:22 GMT
Yes it is. I checked every time to make sure everything I said was part of the TotalFreedom organization You say that but yet none of what you've mentioned was even touched in the latest release. Nobody has raised it as an issue with us before, and if there are bugs, they need to be raised properly so we can investigate. We are aware of a number of bugs we're looking to patch in the 5.1 release, but given everyone involved works full time, we don't want to half arse this through the release just because it needs to be released... It's half baked though, and doesn't have player verification. Just merge the 1.13 branch, and you have your 5.0.1, 5.0.2, and 5.1 release finished. Making separate PR's is frankly a waste of time No... Quite simply put. We won't merge in a 3rd party fork, it's entirely unmanageable for us to QA & test everything in its entirety... We have these guidelines and rules for contributing for a reason. You seem to have an outdated picture of what TFPatches is. I would have agreed that the TotalFreedom TFM was more stable than the one on TFPatches for 1.12 but thats no longer the case anymore. I spent many hours almost everyday going thru TFM and finding issues and making many things better. I would now recommend people using TFPatches. The last commit to TotalFreedom's TFM was over a year ago. The 1.13 branch doesn't work at all (world generation doesn't work) and the devel branch hasn't been updated since August 2017. TFPatches is managed by our active developers who have an actual rank. You really think you're a god because you manage the TotalFreedom organization which has been worked on, but you're not. It's no longer good, it's outdated, and the last release was two years ago. Pull requests are for merging code changes, and issues are where you make them. There is no issue or checklist or anything for the 5.0.1 release. There are no rigorous contribution guidelines on TFPatches and I would rather make quality commits for TFPatches than TotalFreedom. If you are seriously so organized that you have to have the code review on the GitHub, that's really not my problem. The development changelog is listed here and players check the forums, not a GitHub repository. That is the mistake I made with TF-EssentialsX by listing them on some obscure page rather than making an understandable changelog on the forums. TF Patches as far as I am concerned, is nothing more than a fork of the main TotalFreedomMod repo, that's all that matters to me and all I care about. The fact that the main TotalFreedom repo has lacked some of the care it needs is a pain, however I'm trying to get things back up and running without loosing the high quality of code we've always enforced across the plugin. The 1.13 branch is in alpha and is nowhere near ready for testing other than for dev's, the 12.2 branch is what I'm trying to get released in this thread so I can actively work on the 1.13 branch without duplicating my own effort. Change log wise, it's on the TotalFreedomMod releases tab, where we have always put change logs. When the release is actually finalised I will post a thread here, but right now its a pre-release and is only intended for test servers and non-operational environments.
|
|